Repository navigation
fix(music): send Started callbacks for native instant music - #45
Merged
Merged
Conversation
The 1.2 client reacts to its own SCSkillStarted of the play / pause score skills (special effects 93 / 94) with CS121 (MIDI) / CS124 (End). Those skills are instant, so the cast-time-only SCSkillStarted never came and the play effect broadcast an empty MIDI cache. A validated player cast whose catalog join skill_effects -> SpecialEffect -> special_effects has type 93 or 94 now sends SCSkillStarted right before its SCSkillFired; other instant skills, NPC casters, rejected casts and the item-caster refusal are unchanged. Adds goldens, the testclient music commands (m*) and the strict live suites musicrun1 / musicrun2. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Coverage Report for CI Build 40040123456Coverage decreased (-0.2%) to 76.828%Details
Uncovered Changes
Coverage Regressions43 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original 1.2 client only reacts to the play / pause score skills (special effects 93 / 94) when it receives its own non-zero-timeline
SCSkillStarted: that is the trigger for CS121 (MIDI cache) and CS124 (End). Those skills (22213 play, 22214 pause, 22217 close) are instant (casting_time0,effect_delay200 ms), and the server sentSCSkillStartedonly for casts with a cast time. The client therefore never sent CS121 / CS124 and the play effect broadcast an empty MIDI cache.A validated player cast of a skill whose catalog join
skill_effects -> effects(SpecialEffect) -> special_effectscontains type 93 or 94 now sendsSCSkillStartedimmediately before the existingSCSkillFired, with the same non-zero timeline id, cast-time fields 0 and no extra data (skill::schedule_effects,SkillRunState::music_started_pending).Unchanged:
effect_delayand the existingSCSkillFired/ effect timing;use_skillaccepted the cast; rejected casts keep their failureSCSkillStarted);use_skill_id);CSEndMusicPacket: its WARN and the early return while the 30 s ScoreMemorized buff (6010) is active are exactly the old C# behaviour. No End policy change.No ids are hard-coded and there is no
application_methodfilter.Validation
music_started_tests.rs): exact Started bytes and order directly before Fired, the 200 ms effect arriving afterwards, no Started for an unrelated instant skill or a client-only special effect, a rejected cast sends only the failure Started, NPC casters do not qualify.df222a3e1(Scripts/lane.sh check,cargo xtask ci): 3674 passed, 0 failed, 162 ignored. Scoped clippy onaaemu-gameandaaemu-testclient(--all-targets -D warnings) is clean.rust/verify/musicrun1.vtest,musicrun2.vtest; composer + listener, then relogin). They fail on any missing callback, sheet, broadcast or End:SCSendUserMusicto both clients with an identical hash, buff 6177;Limits
effect_delaymeans CS121 / CS122 must reach the server within about 200 ms minus one-way latency of the fire (compose relies on the same window for CS122). Loopback measured ~0 ms; a WAN client was not measured.PORTING.md).Also adds the
m*testclient music commands and aLIVE-TESTING.mdparagraph.Not merged, not deployed to any existing stack.
🤖 Generated with Claude Code